New Keyboard PR #12230
Merged
New Keyboard PR #12230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
keyboard
keymap
via
drashna
requested changes
Mar 17, 2021
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
changes suggested by drashna Co-authored-by: Drashna Jaelre <[email protected]>
fauxpark
requested changes
Mar 18, 2021
keyboards/pkb65/readme.md
Outdated
| @@ -0,0 +1,14 @@ | |||
| # PKB65 | |||
There was a problem hiding this comment.
Please use Unix line endings for this file.
There was a problem hiding this comment.
reuploaded the readme, please see the most recent commit
There was a problem hiding this comment.
Still has Windows line endings.
There was a problem hiding this comment.
ok check it now, should be Unix LF now sorry!
fauxpark
requested changes
Mar 18, 2021
Suggested changes by fauxpark Co-authored-by: Ryan <[email protected]>
Changes suggested by fauxpark Co-authored-by: Ryan <[email protected]>
recreated the readme file with unix EoL in VS Code
EoL Conversion to Unix
fauxpark
approved these changes
Mar 18, 2021
drashna
requested changes
Apr 3, 2021
Co-authored-by: Drashna Jaelre <[email protected]>
drashna
approved these changes
Apr 3, 2021
|
Thanks! |
makenova
pushed a commit
to makenova/qmk_firmware
that referenced
this pull request
Apr 26, 2021
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
HokieGeek
pushed a commit
to HokieGeek/qmk_firmware
that referenced
this pull request
Jul 11, 2021
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
mrtnee
pushed a commit
to mrtnee/qmk_firmware
that referenced
this pull request
Nov 20, 2021
Co-authored-by: Drashna Jaelre <[email protected]> Co-authored-by: Ryan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! I would like to add a new keyboard called the "pkb65."
Description
I have designed a PCB and Keyboard and have completed all prototyping phases. This PR marks the official finalized PCB for production.
Types of Changes
Issues Fixed or Closed by This PR
Checklist